On Thu, Aug 21, 2014 at 7:45 AM, Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote: > On 08/21/2014 02:27 PM, MyungJoo Ham wrote: >>> Thanks for your report. I already sent a patch[1] to fix this build break >>> and I'll send pull request to includec this patch in 3.17-rc2. >>> >>> [1] https://lkml.org/lkml/2014/8/13/761 >>> >>> Best Regards, >>> Chanwoo Choi >> >> I do not object to this patch or your patch[1]. >> >> However, wouldn't it be better to add depends on I2C at REGMAP_I2C? >> When you use REGMAP_I2C, you assume that I2C is already there, don't you? REGMAP_I2C is meant to be "select"ed by its users. So these users should depend on I2C, as "select" does not check dependencies. > The previous REGMAP_I2C has not the dependency on I2C. > So, Greert posted following patch[1] to fix it. > [1] https://lkml.org/lkml/2014/8/17/27 > > Also, if I2C is 'm' (module) and some driver has not dependency on I2C, > build break happen. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
