> Hi Geert > > Thanks for your report. I already sent a patch[1] to fix this build break > and I'll send pull request to includec this patch in 3.17-rc2. > > [1] https://lkml.org/lkml/2014/8/13/761 > > Best Regards, > Chanwoo Choi I do not object to this patch or your patch[1]. However, wouldn't it be better to add depends on I2C at REGMAP_I2C? When you use REGMAP_I2C, you assume that I2C is already there, don't you? Cheers, MyungJoo > > > On 08/17/2014 07:08 PM, Geert Uytterhoeven wrote: > > EXTCON_SM5502 selects REGMAP_I2C, but if I2C=n: > > > > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_read’: > > drivers/base/regmap/regmap-i2c.c:28: error: implicit declaration of function ‘i2c_smbus_read_byte_data’ > > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_byte_reg_write’: > > drivers/base/regmap/regmap-i2c.c:46: error: implicit declaration of function ‘i2c_smbus_write_byte_data’ > > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_read’: > > drivers/base/regmap/regmap-i2c.c:64: error: implicit declaration of function ‘i2c_smbus_read_word_data’ > > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_smbus_word_reg_write’: > > drivers/base/regmap/regmap-i2c.c:82: error: implicit declaration of function ‘i2c_smbus_write_word_data’ > > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_write’: > > drivers/base/regmap/regmap-i2c.c:96: error: implicit declaration of function ‘i2c_master_send’ > > drivers/base/regmap/regmap-i2c.c: In function ‘regmap_i2c_gather_write’: > > drivers/base/regmap/regmap-i2c.c:117: error: implicit declaration of function ‘i2c_check_functionality’ > > drivers/base/regmap/regmap-i2c.c:130: error: implicit declaration of function ‘i2c_transfer’ > > > > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > --- > > drivers/extcon/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > > index 6f2f4727de2c..764f3a113e0a 100644 > > --- a/drivers/extcon/Kconfig > > +++ b/drivers/extcon/Kconfig > > @@ -72,6 +72,7 @@ config EXTCON_PALMAS > > > > config EXTCON_SM5502 > > tristate "SM5502 EXTCON support" > > + depends on I2C > > select IRQ_DOMAIN > > select REGMAP_I2C > > select REGMAP_IRQ > > > > > > > > > > ÿ淸º{.nÇ+돴윯돪†+%듚ÿ깁負¥Šwÿº{.nÇ+돴¥Š{깸-쒩)í끾èw* jgП¨ ¶‰šŽ듶¢jÿ¾?G«앶ÿ◀ ◁¦j:+v돣ŠwèjØm¶Ÿÿ ? ®w?듺þf＂·hš뤴얎ÿ녪¥
