Hi Wolfram, On Mon, Jan 27, 2014 at 5:28 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > >> > You describe what you do, yet the commit message should describe WHY the >> > change is needed. This applies for the other patches as well. >> >> OK, I will add WHY in 2nd version. The ADI TWI peripheral is not >> binding to the Blackfin processor only. It is better to use a more >> generic name for this driver. > > Oh, this is the only reason? Then NACK. Names always change, even > company names. Trying to keep that up-to-date only creates lots of > changes for no technical gain. It is quite common that drivers keep the > name of their first incarnation. This is part of the reason. The other reason is some macro such as SSYNC is blackfin specific. So, all must have SSYNC should be moved into the architecture code. Regards, Sonic -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
