Re: [PATCH 1/4] i2c: rename Blackfin TWI I2C driver to i2c-adi-twi.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Sun, Jan 26, 2014 at 6:28 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> On Sun, Jan 26, 2014 at 03:16:44PM +0800, Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>>
>> Rename twi arch header as well.
>
> You describe what you do, yet the commit message should describe WHY the
> change is needed. This applies for the other patches as well.

OK, I will add WHY in 2nd version. The ADI TWI peripheral is not
binding to the Blackfin processor only. It is better to use a more
generic name for this driver.

>
>>
>> Signed-off-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>
> What is the difference between the two versions you sent? Please always
> describe that.
>

Sorry for the confusion. I didn't receive the first patch set a short
while after I sent them. So, I sent the same patch set again. I should
be more patient.

Thanks

Sonic
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux