Re: [PATCH 1/4] i2c: rename Blackfin TWI I2C driver to i2c-adi-twi.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > You describe what you do, yet the commit message should describe WHY the
> > change is needed. This applies for the other patches as well.
> 
> OK, I will add WHY in 2nd version. The ADI TWI peripheral is not
> binding to the Blackfin processor only. It is better to use a more
> generic name for this driver.

Oh, this is the only reason? Then NACK. Names always change, even
company names. Trying to keep that up-to-date only creates lots of
changes for no technical gain. It is quite common that drivers keep the
name of their first incarnation.

Thanks,

   Wolfram

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux