Jean Delvare said the following: > Hi Michael, Ben, > > On Tue, 07 Dec 2010 12:59:35 +0100, Michael Lawnick wrote: >> Ben Dooks said the following: >> > On Tue, Dec 07, 2010 at 11:06:31AM +0100, Jean Delvare wrote: >> >> Use a function pointer to decide whether to call i2c_add_adapter or >> >> i2c_add_numbered_adapter. This makes the code more compact than the >> >> current strategy of having the common code in a separate function. >> > >> > ok, how about changing i2c_add_numbered_adapter to take a -1 to mean >> > assign bus number automatically? or something similar? >> >> IMHO better: i2c_add_adapter with optional (-1) bus parameter? > > Which problem are you both trying to solve, please? > Function pointers tend to hide information. Seeing the targeted function in source code makes it more clear, IMHO. -- KR Michael -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
