[PATCH] don't add i2c_imx_driver's probe function to the driver struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



i2c_imx_driver is registered using platform_driver_probe which takes
care for the probe function itself.  So don't pass it in the driver
struct, too.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
Cc: Darius Augulis <augulis.darius@xxxxxxxxx>
Cc: Ben Dooks <ben-linux@xxxxxxxxx>
---
Hi Ben,

On Tue, Jul 14, 2009 at 11:55:37PM +0100, Ben Dooks wrote:
> On Sun, Jul 12, 2009 at 10:40:10PM +0200, Wolfram Sang wrote:
> > On Sun, Jul 12, 2009 at 09:53:50PM +0200, Uwe Kleine-K?nig wrote:
> > > i2c_imx_driver is registered using platform_driver_probe which takes
> > > care for the probe function itself.  So don't pass it in the driver
> > > struct, too.
> > > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@xxxxxxxxxxxxxx>
> > > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > > Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > > Cc: Darius Augulis <augulis.darius@xxxxxxxxx>
> > > Cc: Ben Dooks <ben-linux@xxxxxxxxx>
> > 
> > Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > 
> > Adding linux-i2c to CC...
> 
> Can I have the original to apply please?
hhhhmm?  According to my sent mail folder you got a Cc of the original
mail.  Anyhow, here it comes again.  The only difference to the first
post is that Wolfram's Cc: became an Acked-by:

Best regards
Uwe

 drivers/i2c/busses/i2c-imx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 0b486a6..b7a0ac7 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -597,7 +597,6 @@ static int __exit i2c_imx_remove(struct platform_device *pdev)
 }
 
 static struct platform_driver i2c_imx_driver = {
-	.probe		= i2c_imx_probe,
 	.remove		= __exit_p(i2c_imx_remove),
 	.driver	= {
 		.name	= DRIVER_NAME,
-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux