On Mon, Nov 25, 2019 at 4:35 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > 2019年11月25日(月) 4:58 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: > > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > > > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value)); > > > + return sprintf(buf, "%ld", deci_kelvin_to_celsius(value)); > > > > Can you explain the change %lu to %ld? > > Isn't it possible for aux values to be lower than 0 degrees Celsius? If it's a change due to requirement of new helpers, put it in the commit message, otherwise leave as is. -- With Best Regards, Andy Shevchenko