Re: [PATCH 4/8] platform/x86: intel_menlow: switch to use <linux/temperature.h> helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 25, 2019 at 4:35 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> 2019年11月25日(月) 4:58 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
> > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> > > -       return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value));
> > > +       return sprintf(buf, "%ld", deci_kelvin_to_celsius(value));
> >
> > Can you explain the change %lu to %ld?
>
> Isn't it possible for aux values to be lower than 0 degrees Celsius?

If it's a change due to requirement of new helpers, put it in the
commit message, otherwise leave as is.

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux