On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > > This switches the intel_menlow driver to use deci_kelvin_to_celsius() and > celsius_to_deci_kelvin() in <linux/temperature.h> instead of helpers in > <linux/thermal.h>. > > This is preparation for centralizing the kelvin to/from Celsius conversion > helpers in <linux/temprature.h>. > > Cc: Sujith Thomas <sujith.thomas@xxxxxxxxx> > Cc: Darren Hart <dvhart@xxxxxxxxxxxxx> > Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx> > Cc: Zhang Rui <rui.zhang@xxxxxxxxx> > Cc: Eduardo Valentin <edubezval@xxxxxxxxx> > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > Cc: Amit Kucheria <amit.kucheria@xxxxxxxxxxxxx> > Cc: Jean Delvare <jdelvare@xxxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Cc: Keith Busch <kbusch@xxxxxxxxxx> > Cc: Jens Axboe <axboe@xxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Sagi Grimberg <sagi@xxxxxxxxxxx> > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > --- > drivers/platform/x86/intel_menlow.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/intel_menlow.c b/drivers/platform/x86/intel_menlow.c > index b102f6d..6313591 100644 > --- a/drivers/platform/x86/intel_menlow.c > +++ b/drivers/platform/x86/intel_menlow.c > @@ -302,8 +302,10 @@ static ssize_t aux_show(struct device *dev, struct device_attribute *dev_attr, > int result; > > result = sensor_get_auxtrip(attr->handle, idx, &value); > + if (result) > + return result; > > - return result ? result : sprintf(buf, "%lu", DECI_KELVIN_TO_CELSIUS(value)); > + return sprintf(buf, "%ld", deci_kelvin_to_celsius(value)); Can you explain the change %lu to %ld? > } > > static ssize_t aux0_show(struct device *dev, > @@ -332,8 +334,8 @@ static ssize_t aux_store(struct device *dev, struct device_attribute *dev_attr, > if (value < 0) > return -EINVAL; > > - result = sensor_set_auxtrip(attr->handle, idx, > - CELSIUS_TO_DECI_KELVIN(value)); > + result = sensor_set_auxtrip(attr->handle, idx, > + celsius_to_deci_kelvin(value)); How come the first line has been changed? > return result ? result : count; > } > > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko
