On Mon, Nov 25, 2019 at 4:40 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > 2019年11月25日(月) 5:00 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>: > > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > > > DECI_KELVIN_TO_MILLICELSIUS_WITH_OFFSET() is only used by ACPI thermal > > > zone driver and the usage is specific to the driver. So this macro > > > is moved to the ACPI thermal driver rather than generic header. > > > > I didn't get this point. If we split all helpers, let's do it for all, > > and not spreading macro per driver. > > OK, I'll add deci_kelvin_to_millicelsius_with_offset() in the header. Thank you. > But the unit of 'offset' argument will be in millidegree instead of > decidegree, because it's a bit more generic. It's fine as long as the helpers are consolidated and consistent. -- With Best Regards, Andy Shevchenko
