Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs

["Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx>]

On Tue, Sep 06, 2022 at 12:52:48AM +0900, Hector Martin wrote:
> On 05/09/2022 23.01, Russell King (Oracle) wrote:
> > On Mon, Sep 05, 2022 at 04:16:27PM +0300, Andy Shevchenko wrote:
> >> P.S. Do you have a platform to test all these?
> > 
> > Yes, but that doesn't mean I can do testing sufficient to ensure that
> > the modifications are correct. As I understand things, the SMC is not
> > limited to just aarch64 hardware.
> 
> FWIW, the RTKit backend is limited to aarch64 hardware, and that's also
> why I kept all the endian-munging there. T2 and legacy x86 backends
> (which don't exist yet, so whether things need changing for those
> platforms is an open question anyway) would respectively do whatever
> endian-munging is appropriate for them.
> 
> So at this point, only Apple Mx AArch64 SoCs matter, though I *tried* to
> write the code in the way that I thought was most likely to cleanly
> transfer over to other SMC platforms by just changing the backend code.

Right, and that's a good argument not to go and change the smc_key
layout... that invites one hell of a big headache (also for the
reasons you've set out in one of your previous replies.)

I'm going to back out the hex2bin conversion; you've made a good
argument why the code is the way it is. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!