On 05/09/2022 23.01, Russell King (Oracle) wrote: > On Mon, Sep 05, 2022 at 04:16:27PM +0300, Andy Shevchenko wrote: >> P.S. Do you have a platform to test all these? > > Yes, but that doesn't mean I can do testing sufficient to ensure that > the modifications are correct. As I understand things, the SMC is not > limited to just aarch64 hardware. FWIW, the RTKit backend is limited to aarch64 hardware, and that's also why I kept all the endian-munging there. T2 and legacy x86 backends (which don't exist yet, so whether things need changing for those platforms is an open question anyway) would respectively do whatever endian-munging is appropriate for them. So at this point, only Apple Mx AArch64 SoCs matter, though I *tried* to write the code in the way that I thought was most likely to cleanly transfer over to other SMC platforms by just changing the backend code. - Hector