Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs

["Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx>]

On Mon, Sep 05, 2022 at 04:16:27PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 5, 2022 at 4:10 PM Russell King (Oracle)
> <linux@xxxxxxxxxxxxxxx> wrote:
> > On Mon, Sep 05, 2022 at 01:32:29PM +0300, Andy Shevchenko wrote:
> 
> ...
> 
> > Let me say again: I am not changing this. That's for Asahi people to
> > do if they wish. I am the just middle-man here.
> 
> While I agree on technical aspects, this mythical "they" is
> frustrating me. They haven't participated in this discussion (yet?) so
> they do not care, why should we (as a community of upstream)?
> 
> P.S. Do you have a platform to test all these?

Right, having addressed as many review comments as I possibly can, I've
rebuilt and booted it on the platform - and the good news is, it still
works _but_ I don't have enough support in the "mainline" kernel that
I'm testing for anything to make use of any of the interrupt support in
this patch set - so I can't actually test those changes.

I'm going to drop the interrupt patch temporarily as it's unnecessary
for what I want to do, which will be one less patch to worry about.

I still need a resolution between you and Hector over the smc_key
issue - specifically, do I pick up the patch that adds support for
%p4ch, or do we re-architect the smc_key thing and also in doing so
get rid of the need for your "endian conversion" thing.

Given that Hector has rejected some of your comments, I now need to
back out those changes that resulted from your NIH comments.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!