Re: [linusw-pinctrl:devel 26/32] drivers/pinctrl/freescale/pinctrl-imx.c:260:9: error: call to undeclared function 'pinmux_generic_get_function'; ISO C99 and later do not support implicit function declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 5, 2022, at 3:37 PM, Linus Walleij wrote:
> On Mon, Sep 5, 2022 at 3:30 PM Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> >
> What annoys me is that the core pinmux/pinctrl part should not
> depend on HAS_IOMEM... :(

Does it actually still depend on it? s390 now has

config HAS_IOMEM
        def_bool PCI

and compile-test has:

config COMPILE_TEST
        bool "Compile also drivers which will not load"
        depends on HAS_IOMEM

so s390 should work both with and without IOMEM here, as long
as drivers do the usual 'depends on ARCH_MXC || COMPILE_TEST'
dance.

The only problem I see is a missing 'select GENERIC_PINMUX_FUNCTIONS'.
There may be other drivers that have the same issue. Would it
make sense to just always build these into the pinctrl
subsystem?

     Arnd



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux