Re: [linusw-pinctrl:devel 26/32] drivers/pinctrl/freescale/pinctrl-imx.c:260:9: error: call to undeclared function 'pinmux_generic_get_function'; ISO C99 and later do not support implicit function declarations

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Sep 5, 2022 at 3:30 PM Francesco Dolcini
<francesco.dolcini@xxxxxxxxxxx> wrote:
> On Mon, Sep 05, 2022 at 02:36:21PM +0200, Linus Walleij wrote:
> > On Mon, Sep 5, 2022 at 12:25 AM kernel test robot <lkp@xxxxxxxxx> wrote:
> > > >> drivers/pinctrl/freescale/pinctrl-imx.c:288:23: error: use of undeclared identifier 'pinmux_generic_get_function_name'; did you mean 'pinmux_generic_free_functions'?
> > >            .get_function_name = pinmux_generic_get_function_name,
> > >                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >                                 pinmux_generic_free_functions
> >
> > I don't understand this at all, tried to look at it.
> >
> > Francesco, do you have ideas?
>
> Maybe the reason is that before my change the dependency was on
> ARCH_MXC that cannot be compiled in test, while SOC_IMX8M dependency is
> `depends on ARCH_MXC || COMPILE_TEST` leading to all of these.
>
> The trivial fix would be to have the pinctrl dependency on SOC_IMX8M &&
> ARCH_MXC. I'm not convinced is the smartest way but I think it will
> work. What do you think? Should I send a patch or you have a better
> idea?

Hm:
config: s390-buildonly-randconfig-r001-20220905

S390? Yeah that is indeed the problem.

But I suspect it is because S390 doesn't have HAS_IOMEM.

I would add a depends on HAS_IOMEM to something under
Freescale.

What annoys me is that the core pinmux/pinctrl part should not
depend on HAS_IOMEM... :(

Yours,
Linus Walleij