Re: [linusw-pinctrl:devel 26/32] drivers/pinctrl/freescale/pinctrl-imx.c:260:9: error: call to undeclared function 'pinmux_generic_get_function'; ISO C99 and later do not support implicit function declarations

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Sep 5, 2022 at 3:53 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> so s390 should work both with and without IOMEM here, as long
> as drivers do the usual 'depends on ARCH_MXC || COMPILE_TEST'
> dance.

Hm OK

> The only problem I see is a missing 'select GENERIC_PINMUX_FUNCTIONS'.
> There may be other drivers that have the same issue. Would it
> make sense to just always build these into the pinctrl
> subsystem?

That's the thing:
drivers/pinctrl/freescale/Kconfig:

config PINCTRL_IMX
        tristate
        depends on OF
        select GENERIC_PINCTRL_GROUPS
        select GENERIC_PINMUX_FUNCTIONS
        select GENERIC_PINCONF
        select REGMAP

So that is selected, and what we changed was e.g.:

 config PINCTRL_IMX8MM
        tristate "IMX8MM pinctrl driver"
-       depends on ARCH_MXC
+       depends on SOC_IMX8M
        select PINCTRL_IMX
        help
          Say Y here to enable the imx8mm pinctrl driver

so it selects PINCTRL_IMX and that selects GENERIC_PINMUX_FUNCTIONS.

I have a kismet warning that sometimes this selecting PINCTRL_IMX
is inconsistens since it depends on OF and apparently there are
now non-OF configs compiling it. So could the real problem be
that everything selecting PINCTRL_IMX should depend on OF
too?

Yours,
Linus Walleij