I have some patches for the kernel and our userspace code which eliminates the useless readdir buffers. They're a few months old at this point. The problem is that this is already part of the protocol. Unless we decide to change it, we can't very well get out of supporting this. Personally I want to clean this up while we still have the chance. We already plan to only support this module from the latest OrangeFS and up. In either case there's no reason it needs to be so confusing and imply it's shared. Mike, there wouldn't be an unlimited number of buffers. It's still limited by the number of ops which are pre-allocated. -- Martin On 2/12/16, Mike Marshall <hubcap@xxxxxxxxxxxx> wrote: > I'll get the patches today... I have about five small patches > that aren't pushed out to github or kernel.org yet, some > cosmetic patches and a couple of things you suggested > in mail messages... if they get in a fight with your > new patches I'll just ditch them and re-do whichever > ones of them are still needed after I've got your > new stuff tested. > > Thanks! > > -Mike > > On Thu, Feb 11, 2016 at 11:27 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: >> On Wed, Feb 10, 2016 at 10:22:40PM -0500, Mike Marshall wrote: >>> > If there is (or at least supposed to be) something that prevents >>> > completions >>> > of readdir requests (on unrelated directories, by different processes, >>> > etc.) >>> > out of order, PLEASE SAY SO. I would really prefer not to have to >>> > fight >>> > the readdir side of that mess; cancels are already bad enough ;-/ >>> >>> Hi Al... your ideas sound good to me, I'll try to get you good >>> answers on stuff like the above sometime tomorrow... >> >> OK, this is really, really completely untested, might chew your data, >> bugger your dog, etc. OTOH, if it somehow fails to do the above, it >> ought to deal with cancels properly. >> >> Pushed into #orangefs-untested, along with two wait_for_direct_io() fixes >> discussed upthread. This is _not_ all - it still needs saner "wait for >> slot" >> logics, switching op->waitq to completion/killing loop in >> wait_for_matching_downcall(), etc. > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
