On Wed, May 10, 2017 at 10:58 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Fri, May 5, 2017 at 12:58 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> On Fri, May 5, 2017 at 12:53 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >>> On Fri, May 5, 2017 at 9:55 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>>> On Fri, May 5, 2017 at 10:25 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>>>> >>>>> You also forgot to mention in changes since v6: >>>>> >>>>> - store 'null' fh instead of 'invalid' fh >>>> >>>> And w.r.t. that change, the following comment in ovl_get_origin() >>>> is a bit confusing now, because the comment referring to >>>> 'invalid' file handles was removed from the function. >>>> >>>> /* Treat empty origin as "invalid" */ >>> >>> Okay, with cosmetic fixes pushed to overlayfs-next. >> >> Looks good. >> > > Miklos, > > FYI, I have implemented verify_lower mount option: > https://github.com/amir73il/linux/commits/ovl-verify-lower > and tested it below overlay snapshots tests, so for what its worth, > 'store file handle' and 'lookup file handle' from overlayfs-next > (merged to current master) have now been also exercised with lots > of lower changes and mount cycles. > > Is it too soon to nudge you about the pull request? ;-) I'll have a look. My plan is to send a pull request to Linus for the const ino stuff, and then leave the rest to 4.13. This is the list I have in my head for what's missing: - lookup origin dir for snapshots - const ino for non-samefs - correct d_ino for copied up entries - NFS export support - hardlink unbreaking - sharing pages for reflink (*) - ro/rw correctness for samefs with temp reflink (**) - sharing pages in the general case (*) (*) very preliminary design (**) need to check overhead: I have a feeling that it's a heavyweight solution for a tiny problem The non-starred ones don't seem too hard and should aim for 4.13. Thanks, Miklos
