On Fri, May 5, 2017 at 12:53 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Fri, May 5, 2017 at 9:55 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> On Fri, May 5, 2017 at 10:25 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>> >>> You also forgot to mention in changes since v6: >>> >>> - store 'null' fh instead of 'invalid' fh >> >> And w.r.t. that change, the following comment in ovl_get_origin() >> is a bit confusing now, because the comment referring to >> 'invalid' file handles was removed from the function. >> >> /* Treat empty origin as "invalid" */ > > Okay, with cosmetic fixes pushed to overlayfs-next. Looks good. > > I renamed OVL_TYPE_COPYUP to OVL_TYPE_ORIGIN, because, like you said, > the meaning is slightly different. COPYUP means it has been copied > up, ORIGIN means we have a dentry pointing to the origin. > Ack. Thanks, Amir.
