On Fri, May 5, 2017 at 12:58 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Fri, May 5, 2017 at 12:53 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: >> On Fri, May 5, 2017 at 9:55 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>> On Fri, May 5, 2017 at 10:25 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >>>> >>>> You also forgot to mention in changes since v6: >>>> >>>> - store 'null' fh instead of 'invalid' fh >>> >>> And w.r.t. that change, the following comment in ovl_get_origin() >>> is a bit confusing now, because the comment referring to >>> 'invalid' file handles was removed from the function. >>> >>> /* Treat empty origin as "invalid" */ >> >> Okay, with cosmetic fixes pushed to overlayfs-next. > > Looks good. > Miklos, FYI, I have implemented verify_lower mount option: https://github.com/amir73il/linux/commits/ovl-verify-lower and tested it below overlay snapshots tests, so for what its worth, 'store file handle' and 'lookup file handle' from overlayfs-next (merged to current master) have now been also exercised with lots of lower changes and mount cycles. Is it too soon to nudge you about the pull request? ;-) Amir.
