On Thu, May 4, 2017 at 4:14 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > One minor review comment. > > I used uuid_le_cmp(*uuid, NULL_UUID_LE) arbitrarily in my original patch, > but if we want to stick to semantic sb->s_uuid is probably more accurately > described as uuid_be, because filesystems most likely copy it in raw format > from disk. > > This is purely semantic of course, but if you think that matters, may as well > replace uuid_le with uuid_be. Okay. More changes: - use vfs_getattr() to get the lower inode number instead of lower->d_inode->i_ino. For one i_ino is 32bit on 32bit archs, while kstat.ino is always 64bit - merge the dir and non-dir getattr, they look very similar now Pushed to overlayfs-constino.v7 Thanks, Miklos
