>> 1. combine timestamp, count and part into "id". >> for now, in efi-pstore.c, *id = part. and we could simply change it >> to unique one. F.E. *id = (timestamp * 100 + part) * 100 + count. > > My opinion close to 1. > But, the "*id" should not be the complex one like (timestamp * 100 + part) * 100 + count. > Rather, it should be a simple sequential number beginning with 1. I also like option 1 ... but I think the "id" should be a persistent value for a given saved record. So some func(timestamp, part, count) would be a good idea. If we try using "sequential" numbers - and don't manage to clear out /sys/fs/pstore each time - then we may have the same "dmesg" file show up with different names on each boot. Right now I have a simple script to save & clear ... not much more complex than: cd /sys/fs/pstore cp * /var/log/save-pstore rm * This depends on not re-using filenames (otherwise new files in pstore might overwrite older saved files in my /var/log/save-pstore area). -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
