On 03/07/2013 02:15 PM, Matt Fleming wrote: >>> >>> What about a command line option? >> >> That could be done. I'm assuming you want this instead of a config >> option, defaulted to on? >> >> How would you feel about a config option for the default value of the >> command line option? I intend to default this to off in Ubuntu for a >> while as a colleague's machine was recently bricked on two different >> occasions after the kernel oopsed. The config option would simplify >> things a bit for us, though we could always carry a patch changing the >> default value. > > Not sure why a command line option would be a more natural solution to > this problem? The original patch looked fine to me. All other pstore > backends are guarded by Kconfig options. > > Though I could see an argument for a kernel parameter to turn off the > EFI pstore backend code, even if it's compiled into the kernel. But that > would be better as an additional patch. > That way it can be enabled if needed, without the user having to build their own kernel. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
