On Fri, 2013-02-08 at 22:46 +0000, Seiji Aguchi wrote: > > efi_pstore_write() already calls efivar_create_sysfs_entry() which does > > kzalloc() anyway. Obviously this needs fixing, but it doesn't need to be done in this series. Unless there's some pstore patches that fix > > that somewhere? I know you sent some patches that moved things to a thread, unfortunately I haven't had chance to look at them. > > So, could you please take a look at my patch first? > We don't need to introduce bug when we know about it. > > > Isn't the write() path protected by ->buf_lock? I didn't think it was possible to have two CPUs in the write() path simultaneously. > > I see, actual problem will not happen. It's probably still possible to have a CPU creating an EFI variable via the sysfs files while another CPU is in the pstore write path, but I'm not convinced making the query_variable_info() and set_variable() atomic is something that we need to worry about. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
