> efi_pstore_write() already calls efivar_create_sysfs_entry() which does > kzalloc() anyway. Obviously this needs fixing, but it doesn't need to be done in this series. Unless there's some pstore patches that fix > that somewhere? I know you sent some patches that moved things to a thread, unfortunately I haven't had chance to look at them. So, could you please take a look at my patch first? We don't need to introduce bug when we know about it. > Isn't the write() path protected by ->buf_lock? I didn't think it was possible to have two CPUs in the write() path simultaneously. I see, actual problem will not happen. Seiji ��.n��������+%������w��{.n�����{����*jg��������ݢj����G�������j:+v���w�m������w�������h�����٥