Re: [PATCH v2 01/20] efi: Add support for a UEFI variable filesystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2012-11-04 at 21:06 +0000, Alan Cox wrote:
> > +	if (datasize > remaining_size) {
> > +		printk(KERN_ERR "efivars: Variable size too big\n");
> > +		return -ENOSPC;
> 
> Why the printk - you've handed back a sensible error code. If you do have
> a logging result you need to rate limit it as its from the user. I don't
> think you need one - -ENOSPC is pretty clear !

OK, I'll drop the printk.

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux