On Sat, Nov 03, 2012 at 12:22:49AM +0000, Alan Cox wrote: > This still attempts to allocate arbitary user provided values of memory. > This is still broken. Even in the extreme case of 'root only, right thing > to do' then this is broken as you don't pass __GFP_NOWARN. However if you > can have very large strings remember that big values handled this way are > actually effectively implemented as > > "maybe set the value or randomly return -ENOMEM possibly until a > reboot" > > so if your real upper limit is huge then this isn't good. If on the other > hand its things like 32K or so then you just want NOWARN. Yeah. It's fair that this should be limited to whatever QueryVariableInfo() returns on systems that have that, and say 64K on older systems. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
