Hi Tomi,Tomi Orava wrote:> Hi,>> >>>> AFAICS, all channels work here. The remote control also mostly works:>>>> the OK and the blue button don't generate the proper lirc events.>>>> >> I've fixed the remote control key codes as they have been in the original> Cinergy T2 driver with the attached patch. I set the OK to work as enter> and blue to be ESC for test purposes.>> >>> Another glitch:>>>>>> Suspend to RAM doesn't seem to work for some reason. I can log into the>>> computer afterwards, but X stays black.>>> >> Scratch that. The black X screen has nothing to do with the cinergy>> driver. However, I have such messages in the kernel log when I try to>> watch TV:>>>> 2007-10-18_19:11:41.04832 kern.info: cinergyT2: Unhandled remote key>> detected! type=0xffffff90>> >> This is only a debug message. I'd be interested to know from what button> they were generated from. In the long run I'll just disable this message.>> >> 2007-10-18_19:11:41.90423 kern.err: cinergyT2:>> cinergyt2_fe_set_frontend() Failed! err=-75>>>> 2007-10-18_19:11:47.92713 kern.err: cinergyT2:>> cinergyt2_fe_set_frontend() Failed! err=-110>>>> 2007-10-18_19:12:31.94764 kern.err: cinergyT2:>> cinergyt2_fe_read_signal_strength() Failed! (Error=-110)>>>> Of cause, watching TV doesn't work anymore.>> >> It doesn't work because the driver has lost the connection to the USB-device.> Please be sure to try the attached latest version of the driver because> not all> of the oldest one's support sleep modes!>> The problem with removing and reattaching the CinergyT2 usb-device from> the computer without unloading the driver first is a bug of the dvb> framework and of Cinergy's new driver. To my understanding it happens> because the framework calls symbol_put_addr(ptr) for a drivers> fe->ops.release pointer twice. First because the usb system reports the> device as removed and the second time when the frontend-release callback> is being called. This is for sure messes up the module usage counter as> well (ie. you won't be able to unload the Cinergy driver without a> reboot).>> Please try this hack (it's easy to fix it by hand):>> --- a/linux/drivers/media/dvb/dvb-core/dvb_frontend.c Thu Oct 11> 14:09:06 2007 +0200> +++ b/linux/drivers/media/dvb/dvb-core/dvb_frontend.c Wed Oct 24> 20:44:19 2007 +0300> @@ -1209,7 +1209,7 @@ void dvb_frontend_detach(struct dvb_fron> ptr = (void*)fe->ops.release;> if (ptr) {> fe->ops.release(fe);> - symbol_put_addr(ptr);> + /* symbol_put_addr(ptr); */> }> }> #else>> Regards,> Tomi Orava>> PS. Please cc to me next time (without the +linux-dvb part in address)> so that I'll be sure to notice your mail> (I've been a little bit busy for the last few days).>>>>> > ------------------------------------------------------------------------>> _______________________________________________> linux-dvb mailing list> linux-dvb@xxxxxxxxxxx> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvbTested the attached patch on my NSLU2 (266MHz ARM architecture, 32MbRAM), with a debian-arm 2.6.22 (sid) installed.The dvb stream is OK and the driver looks simpler (less code andmodularized).2 minor notes:- you should not put ² for cinergyT2 but '2' in the file headers. Itlooks like that on my system: "Cinergy T�" (UTF8 or something like that).- your patch is missing a newline at the end. This causes an error whenapplied:"patch unexpectedly ends in middle of linepatch: **** malformed patch at line 1017: "
Thanks for this enhancement.Cheers,Thierry
_______________________________________________linux-dvb mailing listlinux-dvb@xxxxxxxxxxxxxxx://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
