Hi Michael, Em Seg, 2007-08-27 às 10:02 -0300, Mauro Carvalho Chehab escreveu:> > I should review the source code later today. Ok. Almost everything looked fine to my eyes. I have just one comment, about the changesets that added theMODULE_DESCRIPTION and MODULE_LICENSE macros, like on this changeset:http://linuxtv.org/hg/~mkrufky/tuner-refactor-phase-1/rev/ff52de4a4da1 This is required at the moment those files will be converted to modules.However, as, currently, they are still part of tuner, you shouldn't addthose lines. On a future changeset where those drivers will be splat, you should alsoadd MODULE_AUTHOR macro. So, I have some comments about that future patch: For tea5767 and tea5761, please add:MODULE_AUTHOR("Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>") For tuner-simple, mt20xx and tda8290, I did some research. Those filesstarted when Gerd split tuner into smaller drivers, removing tuner.cfile, at -hg changeset 1578:http://linuxtv.org/hg/v4l-dvb/file/c9083c80e2f0/linux/drivers/media/video/mt20xx.c Unfortunately, -hg migration didn't preserved the full history (thetuner.c removal changeset is not there). However, we can see the otherside of the history at CVS: http://linuxtv.org/cgi-bin/viewcvs.cgi/video4linux/Attic/tuner.c?root=v4l&view=markup The original module author for tuner.c is marked there as: MODULE_AUTHOR("Ralph Metzler, Gerd Knorr, Gunther Mayer"); This authorship line were preserved at tuner-core.c. The splitting work, however, were done by Gerd. So, IANAL, but, to respect GPL, I can see some ways: a) Preserve the original tuner.c author at the splat drivers; b) Add just "Gerd Knorr" to the splat drivers, and adding a comment, atthe header, stating that mt20xx and tuner-simple are splat driversoriginated from tuner.c, originally written by Ralph Metzler, GerdKnorr, Gunther Mayer. c) Ask the authors for their wishes (as both Gerd and Ralph are likelysubscribed at the ML, probably they'll let us know if they opt for anspecific way. I'm not sure if Gunther is subscribed). For tda8290, maybe Hartmut should also be added, since he reworked somemajor parts of the driver logic: http://linuxtv.org/hg/v4l-dvb/rev/399222ddb2d9 -- Cheers,Mauro _______________________________________________linux-dvb mailing listlinux-dvb@xxxxxxxxxxxxxxx://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
