How to submit a patch to v4l-dvb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello guys,

I've sent twice this patch to , without any
feedback. Maybe that isn't the best way to present myself and my
problem. 

I'm Unai Uribarri, from Spain. I've bought an Hauppaugge WinTV Nova-T
USB2 last month and I begin hacking with it.

My problem is that USB devices comes and goes, and each time I plug the
device I get different device names. I'm so tired of
editing /etc/lirc/lircd.conf and restart lircd, that I've written a
lircd replacement using HAL to detect the hardware hotplugging and the
device name.

But HAL doesn't detect the remote code. So I compared the registration
code with the USB mouse (that works properly) and filled the missing
fields.

Is something wrong in this patch? I tried to follow all the guidelines
about how to write a patch. Will be eventually merged? 

Good bye.

--- Begin Message ---
The registered input device for USB remotes lacks certain fields that
prevents HAL from detecting them. This patch fixes the physical address,
provides a link to its parent device and fills the input identifier.

# HG changeset patch
# User Unai Uribarri <unaiur@xxxxxxxxx>
# Node ID d386c619fb67ae4a2796671ac4971eb32569caec
# Parent  6ddc79dc9d54ce064146b0b6da933b36aa81e513
[PATCH] HAL doesn't detect the DVB USB remotes

From: Unai Uribarri <unaiur@xxxxxxxxx>

The registered input device for USB remotes lacks certain fields that
prevents HAL from detecting them. This patch fixes the physical address,
provides a link to its parent device and fills the input identifier.

Signed-off-by: Unai Uribarri <unaiur@xxxxxxxxx>

diff -r 6ddc79dc9d54 -r d386c619fb67 linux/drivers/media/dvb/dvb-usb/dvb-usb-remote.c
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-remote.c	Sun Jul 23 06:36:05 2006 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-remote.c	Sun Jul 23 12:14:12 2006 +0200
@@ -6,6 +6,7 @@
  * This file contains functions for initializing the the input-device and for handling remote-control-queries.
  */
 #include "dvb-usb-common.h"
+#include <linux/usb_input.h>
 
 /* Remote-control poll function - called every dib->rc_query_interval ms to see
  * whether the remote control has received anything.
@@ -96,7 +97,7 @@ int dvb_usb_remote_init(struct dvb_usb_d
 		return 0;
 
 	usb_make_path(d->udev, d->rc_phys, sizeof(d->rc_phys));
-	strlcpy(d->rc_phys, "/ir0", sizeof(d->rc_phys));
+	strlcat(d->rc_phys, "/ir0", sizeof(d->rc_phys));
 
 	d->rc_input_dev = input_allocate_device();
 	if (!d->rc_input_dev)
@@ -107,6 +108,8 @@ int dvb_usb_remote_init(struct dvb_usb_d
 	d->rc_input_dev->keycodemax = KEY_MAX;
 	d->rc_input_dev->name = "IR-receiver inside an USB DVB receiver";
 	d->rc_input_dev->phys = d->rc_phys;
+	usb_to_input_id(d->udev, &d->rc_input_dev->id);
+	d->rc_input_dev->cdev.dev = &d->udev->dev;
 
 	/* set the bits for the keys */
 	deb_rc("key map size: %d\n", d->props.rc_key_map_size);

--- End Message ---
_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux