On Saturday 08 July 2006 01:16, Trent Piepho wrote: > On Fri, 7 Jul 2006, Andrew de Quincey wrote: > > > Will dvb_attach() work on a static inline non-EXPORT_SYMBOLed function? > > > > Heh, just realised this actually works quite well :) > > > > It doesn't matter - we want the symbol lookup to fail anyway since the > > driver is not compiled in. All the static inline function is doing is > > providing the correct method signature for the XXX_attach() function. > > > > dvb_attach ON, fecustomise ON: > > Uses symbol_get - some symbols are missing since they're defined as > > static inline. symbol_get simply fails to find the symbol. > > dvb_attach ON, fecustomize ON, modules OFF: > symbol_get() _does_ find the static inline stub functions, which return > NULL since that frontend isn't supported. Instead of the "couldn't find FE > attach function" error, you get the "FE attach function failed" error, and > possibly the "trying to use FE that you disabled" warning from the attach > stub. OK you caught me; I was too tired to test that case properly last night :) I wonder.. is that "unable to get function XXX" message actually useful? If someone has intentionally disabled the frontends they don't need, they don't want to see a load of those for the modules they intentionally disabled. (some cards have 3 or 4 possible frontends, and the only way to tell which is to try each in turn). The only messages you'd really care about would be (a) frontend ok, or (b) no frontend found, both of which will still work fine. _______________________________________________ linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
