Re: Increase debug level of debug messages in cx88-mpeg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Trent Piepho wrote:
> On Tue, 18 Apr 2006, Jan Dittmer wrote:
>> Set at least debug level 1 for all debug messages in cx88-mpeg.c to be
>> able to turn them off by setting debug=0. Currently I'm getting
>> about 10k messages per day from this in my syslog without any
>> functional harm.
> 
> I already have a patch that does this in the Hg tree.  Except you turned off
> three dprintk's that I didn't, the irq timeout, irq loop, and irq "general
> errors".  These shouldn't be generated in normal operation and really are
> error conditions, so I thought it was best to leave them on.  I see now that

As the driver seems to have code to recover from these errors it would at least
be nice to turn them off with debug=0 or upgrade them to regular KERN_WARNINGs.
I didn't see these last 3 messages but replaced all debug printks with
level 0 just to be thorough :)

Jan

_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux