>>>>> I'm helping Greg do a bit of cleanup in the staging tree. I noticed >>>>> that >>>>> nobody seems to have worked towards moving line6 out of staging in over >>>>> a year. Are there any plans to clean it up and move it out soon? >>>>> Because >>>>> otherwise we're going to have to delete the driver, as we don't want >>>>> staging to become a permanent place for unfinished code. >>> Do you know of anyone else using this hardware on Linux? yes I, >> Markus Grabner is the maintainer and still the best person to involve. > A while ago I did an online poll among Line6 users and asked who is > interested > in Linux software for Line6 devices, and 2725 people registered, so it's not > just Stefan and me :-) > >> People have popped up from time to time on the line6linux-devel >> mailing list but no one has stuck around: >> http://sourceforge.net/p/line6linux/mailman/line6linux-devel/ >> >>>> It's a shame since the driver is in a pretty good position for further >>>> cleanups and a move out of staging/. There's not that much left to do >>>> but the rate of progress at the moment is zero. >>> >>> If the code is "almost" ready to move, what do you think is left to do? >> >> 1. Run checkpatch.pl again to make sure there are no coding style >> issues remaining. >> >> 2. Audit remaining sysfs attributes and drop them where possible. I >> killed off the easy ones which just sent MIDI messages that userspace >> can send just as easily. Now only the weird ones are left: >> >> drivers/staging/line6/pcm.c:static DEVICE_ATTR_RW(impulse_volume); >> drivers/staging/line6/pcm.c:static DEVICE_ATTR_RW(impulse_period); >> drivers/staging/line6/pod.c:static DEVICE_ATTR_RO(device_id); >> drivers/staging/line6/pod.c:static DEVICE_ATTR_RO(firmware_version); >> drivers/staging/line6/pod.c:static DEVICE_ATTR_RO(serial_number); >> drivers/staging/line6/toneport.c:static DEVICE_ATTR(led_red, S_IWUSR | >> S_IRUGO, line6_nop_read, >> drivers/staging/line6/toneport.c:static DEVICE_ATTR(led_green, S_IWUSR >> | S_IRUGO, line6_nop_read, > I agree that it's better to have a stripped down driver than no driver at > all. I think I can do this kind of cleaning stuff in the next few weeks, and I have needed hardware to test. -- « On ne résout pas un problème avec les modes de pensée qui l’ont engendré. » « You cannot solve current problems with current thinking. Current problems are the result of current thinking » _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
