Re: [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-06-19 at 21:20 +0200, Johannes Stadlinger wrote:
> This patch fixes all warning of checkpatch about lines over 80
> characters.

trivia:

> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
[]
> @@ -1271,7 +1275,8 @@ void prism2sta_processing_defer(struct work_struct *data)
>  				     HFA384x_RID_CURRENTSSID, result);
>  				return;
>  			}
> -			prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid,
> +			prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *)
> +									&ssid,
>  						(p80211pstrd_t *) &
>  						wlandev->ssid);

I don't find this better or easier to read.

Sometimes it's easier to read to cast to a
void * instead of the specific type

			prism2mgmt_bytestr2pstr((void *)&ssid,
						(void *)&wlandev->ssid);

 



_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux