On Thu, Jun 19, 2014 at 09:20:20PM +0200, Johannes Stadlinger wrote:
> This patch inserts blank lines after declarations to avoid checkpatch
> warnings.
>
> After our fixes in 'wlan-ng/prism2sta' there is still a checkpatch
> warning about prefering 'ether_addr_copy' instead of 'memcpy'
> remaining.
>
> Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@xxxxxx>
> Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
> CC: linux-kernel@xxxxxxxxxxxx
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: Tugce Sirin <ztugcesirin@xxxxxxxxx>
> CC: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> CC: Himangi Saraogi <himangi774@xxxxxxxxx>
> CC: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> CC: Vitaly Osipov <vitaly.osipov@xxxxxxxxx>
> CC: Neil Armstrong <superna9999@xxxxxxxxx>
> CC: devel@xxxxxxxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
This one does look like an improvement.
Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> drivers/staging/wlan-ng/prism2sta.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
> index 9444006..8d4d7ba 100644
> --- a/drivers/staging/wlan-ng/prism2sta.c
> +++ b/drivers/staging/wlan-ng/prism2sta.c
> @@ -360,6 +360,7 @@ static int prism2sta_mlmerequest(wlandevice_t *wlandev, struct p80211msg *msg)
> case DIDmsg_lnxreq_ifstate:
> {
> struct p80211msg_lnxreq_ifstate *ifstatemsg;
> +
> pr_debug("Received mlme ifstate request\n");
> ifstatemsg = (struct p80211msg_lnxreq_ifstate *) msg;
> result =
> @@ -1411,6 +1412,7 @@ void prism2sta_processing_defer(struct work_struct *data)
> */
> if (hw->join_ap && --hw->join_retries > 0) {
> hfa384x_JoinRequest_data_t joinreq;
> +
> joinreq = hw->joinreq;
> /* Send the join request */
> hfa384x_drvr_setconfig(hw,
> --
> 1.9.1
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
