On Thu, 2014-06-19 at 13:14 -0700, josh@xxxxxxxxxxxxxxxx wrote: > On Thu, Jun 19, 2014 at 09:20:17PM +0200, Johannes Stadlinger wrote: > > This patch inserts blank lines after declarations to avoid checkpatch > > warning. [] > > diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c [] > > @@ -85,7 +85,8 @@ struct mibrec { > > u16 parm1; > > u16 parm2; > > u16 parm3; > > - int (*func) (struct mibrec *mib, > > + > > + int (*func)(struct mibrec *mib, > > Eliminating the space here makes sense, but checkpatch shouldn't warn > about spaces after declarations between two fields in the middle of a > structure declaration. It's a defect in checkpatch, It's fixed in the latest version in -next https://lkml.org/lkml/2014/6/6/426 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel