On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote: > Hey Guys, > So Sorry about wasting your time with bad patchs. > I feel bad about that. I hope this patch is O.K. > now. :( It's not. > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c [] > > @@ -59,7 +58,9 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, > > bLastIniPkt = 1; > > > > } > > - > > + skb = dev_alloc_skb(frag_length + 4); > > + if (!skb) > > + return false; > > skb = dev_alloc_skb(frag_length + 4); You're still wasting time and not thoroughly reading your own patches. You've duplicated the dev_alloc_skb line. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel