On Thu, Jun 19, 2014 at 09:20:18PM +0200, Johannes Stadlinger wrote: > This patch fixes all warning of checkpatch about lines over 80 > characters. > > Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@xxxxxx> > Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email> > CC: linux-kernel@xxxxxxxxxxxx > CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > CC: Tugce Sirin <ztugcesirin@xxxxxxxxx> > CC: Josh Triplett <josh@xxxxxxxxxxxxxxxx> > CC: Neil Armstrong <superna9999@xxxxxxxxx> > CC: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > CC: Vitaly Osipov <vitaly.osipov@xxxxxxxxx> > CC: devel@xxxxxxxxxxxxxxxxxxxx > CC: linux-kernel@xxxxxxxxxxxxxxx Most of these look fine, but... > @@ -1271,7 +1275,8 @@ void prism2sta_processing_defer(struct work_struct *data) > HFA384x_RID_CURRENTSSID, result); > return; > } > - prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid, > + prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) > + &ssid, > (p80211pstrd_t *) & > wlandev->ssid); ...that (and the one in the subsequent context lines) looks horrible. I'd suggest breaking after the opening parenthesis of the function call and just indenting the arguments by one tab: foo_with_long_name( long_arg, another_long_arg); Better yet, ignore checkpatch and format that call more readably as though the 80 column rule didn't exist. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
