Re: [PATCH 07/23] staging: xgifb: avoid direct references xgi_video_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 10, 2011 at 12:31:21AM +0300, Aaro Koskinen wrote:
> Sorry, I misunderstood the question. DISPTYPE_DISP2 is used to get the
> type of the second output/port. It can be CRT2, LCD, or TV but only one
> of them is set at a time, so the code should work. Then there is also
> the first display port, which is always hardcoded to CRT1 (the external
> VGA output). So CRT+LCD is possible but not in the same output.
> 

Ah.  Gotcha.  That works.  But it's still not pretty.  Bitfields are
for storing when a variable can have multiple attributes at once.

DISPTYPE_CRT1 gets set but never used.
Same for DISPMODE_MIRROR and DISPMODE_SINGLE as you pointed out.
The types of the second display are mutually exclusive.

So I mean, it sounds like we agree on this actually.  Thanks for
explaining.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux