Hi, These are the start of cleanups for the global variable and static data usage. The driver should allocate all device-specific data in probe and release it when the module is removed. Static data is used only for the module and fb parameters. The patches are based and tested on top of the current staging-next (93decf3661bf1c7c05bbc217d4e69222b557512a). Testing: - compile-tested with GCC 4.6.1 + sparse, no warnings. - tested with Z9 (XG21) on ARM, with external VGA display, framebuffer console works Aaro Koskinen (23): staging: xgifb: use PCI drvdata staging: xgifb: eliminate global fb_info variable staging: xgifb: eliminate global XGIhw_ext data staging: xgifb: inline XGIfb_query_VGA_config_space() staging: xgifb: add a global variable for the default refresh rate staging: xgifb: rename struct video_info to xgifb_video_info staging: xgifb: avoid direct references xgi_video_info staging: xgifb: dynamically allocate xgifb_video_info staging: xgifb: eliminate XGIfb_mode_no staging: xgifb: move xgifb_mode_idx into xgifb_video_info staging: xgifb: move XGIfb_rate_idx into xgifb_video_info staging: xgifb: move pseudo_palette into xgifb_video_info staging: xgifb: eliminate XGIfb_CRT2_write_enable variable staging: xgifb: eliminate default_var staging: xgifb: eliminate XGIfb_fix staging: xgifb: eliminate filter_tb global variable staging: xgifb: make XGIbios_mode const staging: xgifb: eliminate global XGI_Pr data staging: xgifb: move XGINew_RAMType into vb_device_info staging: xgifb: move XGINew_ChannelAB into vb_device_info staging: xgifb: move XGINew_DataBusWidth into vb_device_info staging: xgifb: make RAM type tables const staging: xgifb: make DAC tables const drivers/staging/xgifb/XGI_main.h | 79 +--- drivers/staging/xgifb/XGI_main_26.c | 853 ++++++++++++++++++----------------- drivers/staging/xgifb/XGIfb.h | 17 +- drivers/staging/xgifb/vb_init.c | 235 +++++----- drivers/staging/xgifb/vb_init.h | 2 +- drivers/staging/xgifb/vb_setmode.c | 11 +- drivers/staging/xgifb/vb_struct.h | 4 + drivers/staging/xgifb/vgatypes.h | 4 - 8 files changed, 590 insertions(+), 615 deletions(-) -- 1.7.2.5 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel