Re: [PATCH 07/23] staging: xgifb: avoid direct references xgi_video_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 09, 2011 at 07:42:51PM +0300, Aaro Koskinen wrote:
> -	switch (xgi_video_info.disp_state & DISPTYPE_DISP2) {
> +	switch (xgifb_info->disp_state & DISPTYPE_DISP2) {

This isn't related to this patch, but this data type is weird.

It would be probably be more natural to break up ->disp_state into
two variables where one stored the display type and one stored the if
the displays were mirrored or single.  Can you connect a CRT and an
LCD at the same time?

Sorry if I'm asking stupid questions...

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux