Re: [PATCH 18/23] staging: xgifb: eliminate global XGI_Pr data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 09, 2011 at 07:43:02PM +0300, Aaro Koskinen wrote:
> @@ -2292,7 +2294,9 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
>  				XGIbios_mode[xgifb_info->mode_idx].xres) &&
>  			    (XGI21_LCDCapList[m].LVDSVDE ==
>  				XGIbios_mode[xgifb_info->mode_idx].yres)) {
> -				xgifb_reg_set(XGI_Pr.P3d4, 0x36, m);
> +				xgifb_reg_set(xgifb_info->dev_info.P3d4,
> +					      0x36,
> +					      m);

You just put that there to see if we read your patches.  We noticed
it, but we're not going to comment on tiny whitespace details.  Don't
resend.

>  				break;
>  			}
>  	}

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux