Re: [PATCH 07/23] staging: xgifb: avoid direct references xgi_video_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 09, 2011 at 07:42:51PM +0300, Aaro Koskinen wrote:
> @@ -1163,17 +1166,17 @@ static int XGIfb_do_set_var(struct fb_var_screeninfo *var, int isactive,
>  	if (var->pixclock && htotal && vtotal) {
>  		drate = 1000000000 / var->pixclock;
>  		hrate = (drate * 1000) / htotal;
> -		xgi_video_info.refresh_rate = (unsigned int) (hrate * 2
> +		xgifb_info->refresh_rate = (unsigned int) (hrate * 2
>  				/ vtotal);

You could remove the cast to (unsigned int) and it would all fit on
one line.  (In a follow on patch.  Don't resend).

> @@ -1477,15 +1488,15 @@ static int XGIfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
>  	if (var->pixclock && htotal && vtotal) {
>  		drate = 1000000000 / var->pixclock;
>  		hrate = (drate * 1000) / htotal;
> -		xgi_video_info.refresh_rate =
> +		xgifb_info->refresh_rate =
>  			(unsigned int) (hrate * 2 / vtotal);

Same.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux