Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2018 at 4:12 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote:
>> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote:
>> > From: Todd Poynor <toddpoynor@xxxxxxxxxx>
>> >
>> > Return right away instead of break out of while and then return.
>> >
>>
>
> Btw, I wasn't going to complain about this but since Greg is being extra
> critical about commit messages that don't explain *why* it just creates
> an environment why I also feel free to complain...  I couldn't
> understand what this commit does without looking at the code in context.
>
> A possible commit message here is:
>
> [PATCH 12/32] staging: gasket: small cleanup in gasket_wait_with_reschedule()
>
> gasket_wait_with_reschedule() is a little more clear if we just return
> directly.

I've updated the text for v3, thanks -- Todd

>
> regards,
> dan carpenter
>



-- 
Todd
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux