Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote:
>> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
>>
>> Return right away instead of break out of while and then return.
>>
>
> You could remove the (retries == max_retries) condition since that's
> always true now and pull that code in one tab.  You could do it in one
> patch because they're closely related so it's One Thing [tm].

Ah yes, also removed the impossible-to-reach "return 0" at the end,
thanks -- Todd

>
> regads,
> dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux