From: Todd Poynor <toddpoynor@xxxxxxxxxx> Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Various (32): staging: gasket: remove X86 Kconfig restriction staging: gasket: fix typo in apex_enter_reset staging: gasket: fix typo in gasket_core.h comments staging: gasket: whitespace fix in gasket_page_table_init staging: gasket: remove driver registration on class creation failure staging: gasket: hold mutex on gasket driver unregistration staging: gasket: Return EBUSY on mapping create when already in use staging: gasket: Remove stale pointers on error allocating attr array staging: gasket: convert gasket_mmap_has_permissions to bool return staging: gasket: fix gasket_wait_with_reschedule timeout return code staging: gasket: gasket_wait_with_reschedule use msleep staging: gasket: gasket_wait_with_reschedule return when condition hit staging: gasket: gasket_wait_with_reschedule use 32 bits of retry count staging: gasket: bail out of reset sequence on device callback error staging: gasket: drop gasket_cdev_get_info, use container_of staging: gasket: always allow root open for write staging: gasket: annotate ioctl arg with __user staging: gasket: gasket_enable_dev remove unnecessary variable staging: gasket: remove code for no physical device staging: gasket: fix class create bug handling staging: gasket: remove unnecessary code in coherent allocator staging: gasket: don't treat no device reset callback as an error staging: gasket: gasket_mmap return error instead of valid BAR index staging: gasket: apex_clock_gating simplify logic, reduce indentation staging: gasket: apex_ioctl_check_permissions use bool return type staging: gasket: gasket page table functions use bool return type staging: gasket: remove else clause after return in if clause staging: gasket: fix comment syntax in apex.h staging: gasket: remove unnecessary parens in page table code staging: gasket: gasket_mmap use PAGE_MASK staging: gasket: remove extra parens in gasket_write_mappable_regions staging: gasket: fix multi-line comment syntax in gasket_core.h drivers/staging/gasket/Kconfig | 2 +- drivers/staging/gasket/apex.h | 7 +- drivers/staging/gasket/apex_driver.c | 79 ++++++++-------- drivers/staging/gasket/gasket_core.c | 105 +++++++++------------ drivers/staging/gasket/gasket_core.h | 11 ++- drivers/staging/gasket/gasket_ioctl.c | 91 +++++++++--------- drivers/staging/gasket/gasket_ioctl.h | 4 +- drivers/staging/gasket/gasket_page_table.c | 67 +++++++------ drivers/staging/gasket/gasket_page_table.h | 8 +- drivers/staging/gasket/gasket_sysfs.c | 4 +- 10 files changed, 177 insertions(+), 201 deletions(-) -- 2.18.0.203.gfac676dfb9-goog Patches changed from version 1: staging: gasket: typo and whitespace cleanups Split into new separate patches: staging: gasket: whitespace fix in gasket_page_table_init staging: gasket: fix typo in gasket_core.h comments staging: gasket: fix typo in apex_enter_reset staging: gasket: device registration error and unregister fixups Split into new separate patches: staging: gasket: remove driver registration on class creation failure staging: gasket: hold mutex on gasket driver unregistration staging: gasket: sysfs mapping creation fixups Split into new separate patches: staging: gasket: Return EBUSY on mapping create when already in use staging: gasket: Remove stale pointers on error allocating attr array staging: gasket: gasket_wait_with_reschedule fixups Split into new separate patches: staging: gasket: fix gasket_wait_with_reschedule timeout return code staging: gasket: gasket_wait_with_reschedule use msleep staging: gasket: gasket_wait_with_reschedule return when condition hit staging: gasket: gasket_open use container_of() Replaced by new patch: staging: gasket: drop gasket_cdev_get_info, use container_of staging: gasket: always allow root open for write Add Reviewed-by from Dmitry Torokhov. staging: gasket: gasket_enable_dev fixups Split into new separate patches: staging: gasket: gasket_enable_dev remove unnecessary variable staging: gasket: remove code for no physical device staging: gasket: fix class create bug handling Add Reviewed-by from Dmitry Torokhov. staging: gasket: gasket core error handling fixups Split into new separate patches: staging: gasket: don't treat no device reset callback as an error staging: gasket: gasket_mmap return error instead of valid BAR index staging: gasket: various cleanups Split into new separate patches: staging: gasket: apex_clock_gating simplify logic, reduce indentation staging: gasket: apex_ioctl_check_permissions use bool return type staging: gasket: gasket page table functions use bool return type staging: gasket: remove else clause after return in if clause staging: gasket: fix comment syntax in apex.h staging: gasket: remove unnecessary parens in page table code staging: gasket: gasket_mmap use PAGE_MASK staging: gasket: remove extra parens in gasket_write_mappable_regions staging: gasket: fix multi-line comment syntax in gasket_core.h Patches dropped from version 1: MAINTAINERS: Add maintainer for drivers/staging/gasket Need to arrange a positive handoff from existing maintainer, not available now. staging: gasket: fix deadlock in pci driver unregister path Wrapped PCI calls broken, needs a rewrite. staging: gasket: don't release coherent mappings Not necessary. Patches unchanged from version 1: staging: gasket: remove X86 Kconfig restriction staging: gasket: convert gasket_mmap_has_permissions to bool return staging: gasket: bail out of reset sequence on device callback error staging: gasket: always allow root open for write staging: gasket: annotate ioctl arg with __user staging: gasket: remove unnecessary code in coherent allocator _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel