On Tue, Jun 25, 2013 at 2:29 PM, Christian Ruppert <christian.ruppert@xxxxxxxxxx> wrote: > On Mon, Jun 03, 2013 at 10:51:06AM +0100, Grant Likely wrote: >> On Mon, Jun 3, 2013 at 5:05 AM, Vineet Gupta <Vineet.Gupta1@xxxxxxxxxxxx> wrote: >> > On 06/01/2013 03:48 AM, Grant Likely wrote: >> >> If I were working on this system I'd drop the >> >> snps,arc700-intc node entirely and have a single abilis,tb10x-intc that >> >> encapsulated the properties of both (you would of course want to share >> >> handler functions for the 'normal' inputs without the custom features). >> >> That would eliminate the goofyness of listing 27 separate interrupts in >> >> the abilis,tb10x-ictl interrupts property. >> > >> > But how is this different from other systems with a primary in-core intc and a >> > cascaded external intc. How do they do it. I guess I need to read up more on this. >> >> Usually cascaded irq controllers have multiple irqs multiplexed onto a >> single irq on the parent controller. It's the 1:1 situation that makes >> this controller odd. > > You're right, this might be a bit confusing. The controller was mainly > designed as a compatibility layer between ARC770 built-in interrupts and > the rest of the system. > > Do you see a better way to drive this kind of hardware? Do you have any > other comments on the driver? > > Without this driver, arch/arc/plat-tb10x and related drivers will not > work and it would thus be good to have this in the kernel as quickly as > possible if there are no more issues with it. No, I don't have any other issues with it. It is unconventional, but the framework handles it fine the way you've set it up. g. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
