On Thu, Mar 06, 2025 at 09:29:42AM -0800, Eric Biggers wrote: > > Those unions are ugly, but I guess this is good enough. Please also delete the > /* XXX */ comments, fix the typo in the title, and resend this as a real patch. I'm going to keep the XXX comments, which is more about the fact that we're mixing skcipher_map/unmap with skcipher_next and skcipher_done_src/dst. But I will add a new comment to skcipher_walk to make the virt fields the official way of accessing the pointer. That way the user is guaranteed to not change it from under us. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
