Re: [PATCH] crypto: scatterwalk - Change scatterwalk_next calling convention

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 06, 2025 at 10:52:48AM +0800, Herbert Xu wrote:
> Rather than returning the address and storing the length into an
> argument pointer, add an address field to the walk struct and use
> that to store the address.  The length is returned directly.
> 
> Change the done functions to use this stored address instead of
> getting them from the caller.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Why?  All the callers keep track of the address anyway.  I don't see a need to
bloat the scatter_walk structure beyond a simple (sg, offset) pair.

- Eric




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]
  Powered by Linux