On Wed, Mar 05, 2025 at 07:36:58PM -0800, Eric Biggers wrote: > > That's exactly what happens to struct skcipher_walk. This patch adds two > redundant pointers to it. Yes it's allocated on the stack, but it's still not a > great result. I forgot to mention that :) I marked a few places in the patch with XXXs to indicate where the API is being abused. skcipher_walk happens to be one of them where it's mixing the new done calls with the old map call. So I will come back to this and fix it to use the new next call instead. At that point I intend to have exactly one virtual pointer each for src/dst in skcipher_walk, probably the new one that I've just added to scatterwalk. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
